-
Notifications
You must be signed in to change notification settings - Fork 53
Add k8s-1.35 and ecr-credential-provider-1.35 pkgs with pre-release sources #777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ddd6009 to
2327d00
Compare
56dd7f7 to
d1119e0
Compare
packages/ecr-credential-provider-1.35/ecr-credential-provider-1.35.spec
Outdated
Show resolved
Hide resolved
packages/ecr-credential-provider-1.35/ecr-credential-provider-1.35.spec
Outdated
Show resolved
Hide resolved
packages/ecr-credential-provider-1.35/ecr-credential-provider-1.35.spec
Outdated
Show resolved
Hide resolved
packages/ecr-credential-provider-1.35/ecr-credential-provider-1.35.spec
Outdated
Show resolved
Hide resolved
d1119e0 to
473aa56
Compare
koooosh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should fix the Release field for ECR cred provider, but the rest are just nits
packages/ecr-credential-provider-1.35/ecr-credential-provider-1.35.spec
Outdated
Show resolved
Hide resolved
Add ecr-credential-provider for Kubernetes 1.35. Uses cloud-provider-aws v1.35.0 source. Signed-off-by: Yutong Sun <yutongsu@amazon.com>
473aa56 to
398157c
Compare
|
Force push to address comments from @koooosh |
Signed-off-by: Yutong Sun <yutongsu@amazon.com>
398157c to
d0ef3d3
Compare
koooosh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rpm info for ecr-credential-provider-1.35 needs to be updated in the description since we updated some of the fields, but overall LGTM.
Issue number:
Related to: bottlerocket-os/bottlerocket#4725
Description of changes:
Initial set of changes for kubernetes 1.35 support:
Key changes:
--pod-infra-container-imagekubelet flag (removed upstream in 1.35)Testing done:
kubelet version is reported correctly
rpmvercmpTerms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.