Skip to content

kmod-6.12-nvidia-r570: add common module file for linking#234

Merged
dhwaniserai merged 1 commit intobottlerocket-os:developfrom
dhwaniserai:vermagic
Aug 18, 2025
Merged

kmod-6.12-nvidia-r570: add common module file for linking#234
dhwaniserai merged 1 commit intobottlerocket-os:developfrom
dhwaniserai:vermagic

Conversation

@dhwaniserai
Copy link
Copy Markdown
Contributor

@dhwaniserai dhwaniserai commented Aug 6, 2025

Issue number:

Closes #176

Description of changes:

  • Add module-common.o to nvidia driver spec
  • This change is necessary due to this commit changing the linking of constants in upstream.

Testing done:

  • Built a custom AMI with kernel-kit v4.0.1 and bottlerocket v1.44.0
  • Deployed a pod with the latest aws-k8s-nvidia variant for aarch64 and x86_64

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@dhwaniserai dhwaniserai marked this pull request as ready for review August 8, 2025 23:33
@dhwaniserai dhwaniserai requested review from bcressey and rpkelly August 8, 2025 23:34
@dhwaniserai dhwaniserai changed the title kernel-6.12: add patch to include vermagic string kmod-6.12-nvidia-r570: add common module file for linking Aug 13, 2025
Comment thread packages/kmod-6.12-nvidia-r570/kmod-6.12-nvidia-r570.spec
@dhwaniserai
Copy link
Copy Markdown
Contributor Author

force push refers to update in license for the tesla subpackage in the spec

%dir %{_cross_libdir}/nvidia/tesla
%dir %{_cross_libexecdir}/nvidia/tesla/bin

%{_cross_datadir}/nvidia/tesla/module-objects.d/.module-common.o
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this should go in the "# driver" section below with the other module-objects.d artifacts

@dhwaniserai
Copy link
Copy Markdown
Contributor Author

force push refers to file section change in the spec for the feedback above.

Comment thread packages/kmod-6.12-nvidia-r570/nvidia-tesla-build-config.toml.in
Signed-off-by: Dhwani Serai <dhwanise@amazon.com>
@dhwaniserai
Copy link
Copy Markdown
Contributor Author

force push links the module-common file to all the runtime .ko files.

@dhwaniserai dhwaniserai merged commit dfdb02d into bottlerocket-os:develop Aug 18, 2025
2 checks passed
@dhwaniserai dhwaniserai deleted the vermagic branch August 18, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vermagic error with nvidia r570 kmod for 6.12

5 participants