feat: add support for nvidia MIG#35
Merged
arnaldo2792 merged 3 commits intobottlerocket-os:developfrom Feb 6, 2025
Merged
Conversation
ff38305 to
bb3c90a
Compare
bcressey
reviewed
Feb 5, 2025
| error::GpuModelSnafu | ||
| ); | ||
|
|
||
| if pci_device_id.starts_with("0x20B0") { |
Contributor
There was a problem hiding this comment.
nit: maybe not worth doing, but you could repeat the serde alias approach and deserialize the enum variant from the PCI device ID.
cb05c7e to
2957c9e
Compare
Contributor
Author
|
Force push fixes all the comments. |
KCSesh
reviewed
Feb 6, 2025
KCSesh
reviewed
Feb 6, 2025
2957c9e to
152f693
Compare
Contributor
Author
|
Force push fixes the above comments. |
KCSesh
approved these changes
Feb 6, 2025
bcressey
approved these changes
Feb 6, 2025
152f693 to
e6e1e1c
Compare
Contributor
Author
|
Fixed the above 2 comments |
arnaldo2792
approved these changes
Feb 6, 2025
| Version: 0.1 | ||
| Release: 1%{?dist} | ||
| Epoch: 1 | ||
| Summary: Tool to generate NVIDIA MIG Binary and config files |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| Summary: Tool to generate NVIDIA MIG Binary and config files | |
| Summary: Tool manage NVIDIA MIG and its config files |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number:
Related:
Description of changes:
Adding nvidia-migmanager service and binary that configures the instance with nvidia mig.
Testing done:
kubectl describe nodeshows 56 gpus post instance reboot.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.