Oci hooks settings extension#3978
Merged
mgsharm merged 3 commits intobottlerocket-os:developfrom May 22, 2024
Merged
Conversation
deb3cfb to
d03e55b
Compare
webern
approved these changes
May 22, 2024
d03e55b to
9b8eae1
Compare
sumukhballal
approved these changes
May 22, 2024
9b8eae1 to
9caf44f
Compare
sam-berning
approved these changes
May 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #3659
Description of changes:
ock-hookssettings extension and uses it in every variant's settings model.settings-oci-hooksRPM package that installs the extension binary.Testing done:
aws-devvariant with thesettings-oci-hooksinstalled. Launchedec2instance with theaws-devvariant ami. Connected with the instance viaSSMto runapiclientcommands.settings-oci-hooksworked as expected.[ssm-user@control]$ apiclient get settings.oci-hooks { "settings": { "oci-hooks": { "log4j-hotpatch-enabled": false } } } [ssm-user@control]$ apiclient set settings.oci-hooks.log4j-hotpatch-enabled=true [ssm-user@control]$ apiclient get settings.oci-hooks { "settings": { "oci-hooks": { "log4j-hotpatch-enabled": true } } }Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.