Skip to content
This repository was archived by the owner on Dec 24, 2025. It is now read-only.

Comments

Profile refactor#562

Merged
hamzaakyildiz merged 4 commits intodevelopmentfrom
profile-refactor
Dec 24, 2021
Merged

Profile refactor#562
hamzaakyildiz merged 4 commits intodevelopmentfrom
profile-refactor

Conversation

@hamzaakyildiz
Copy link
Collaborator

Proposed changes

get-set profile is refactored according to feedback from the frontend and mobile team

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@hamzaakyildiz hamzaakyildiz added Status: Done Completed Issues Priority: Medium Needs to be handled Backend Backend development labels Dec 23, 2021
@hamzaakyildiz hamzaakyildiz self-assigned this Dec 23, 2021
@hamzaakyildiz hamzaakyildiz linked an issue Dec 23, 2021 that may be closed by this pull request
Copy link
Collaborator

@efesabanogluu efesabanogluu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works

@hamzaakyildiz hamzaakyildiz merged commit bb3e0d6 into development Dec 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Backend Backend development Priority: Medium Needs to be handled Status: Done Completed Issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Get Profile Information Refactor

2 participants