Merged
Conversation
The method has been removed since v4.0.0 It was working in v3.1 Adding checks now and throw if any of the options are set is to late, as most code is probably ported by now.
ZedThree
approved these changes
Apr 19, 2018
Member
|
Just to note that |
Contributor
|
A note on this: test-ballooning was used during the transition, to ensure that the old and new methods gave the same results. Now that the old method has been removed (as of v4), this test is indeed obsolete. More tests should of course be added to test the shifted metric and ballooning transform methods. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method has been removed since v4.0.0
It was working in v3.1
Adding checks now and throw if any of the options are set is to late, as
most code is probably ported by now.
Resolves #985