Set result location in Delp2 from incoming field#1124
Merged
ZedThree merged 1 commit intoboutproject:nextfrom Jun 19, 2018
Merged
Set result location in Delp2 from incoming field#1124ZedThree merged 1 commit intoboutproject:nextfrom
ZedThree merged 1 commit intoboutproject:nextfrom
Conversation
Contributor
|
This seems sensible, and is consistent with what the rest of the code does at the moment. Delp2 should be location dependent in the metric terms in the call to tridagcoefs, which is addressed in #1060. |
johnomotani
approved these changes
Jun 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delp2 doesn't currently handle staggered fields and throws when the input field is not cell centred.
I don't think Delp2 needs to be stagger aware since it operates on xz slices. So I think setting the result location based on the input field fixes the problem.