Conversation
and Tensor Currently set this to `int` whilst previous behaviour would be equivalent to `unsigned int`. The motivation for changing to `int` is that this allows `operator()` uses to vectorise when in loops with an `int` index. Changing loop indices to `unsigned int` (or `std::size_t`) doesn't actually allow vectorisation even when `Matrix::size_type = std::size_t` as `Array` currently also uses `int` as the indexing type. This seems to be enough to prevent vectorisation in simple loops over `Matrix` elements.
bendudson
approved these changes
Aug 20, 2018
Member
|
Long-term, this should use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
size_typeto define the type of size related variables in Matrix and TensorCurrently set this to
intwhilst previous behaviour would beequivalent to
unsigned int. The motivation for changing tointisthat this allows
operator()uses to vectorise when in loops with anintindex.Changing loop indices to
unsigned int(orstd::size_t) doesn'tactually allow vectorisation even when
Matrix::size_type = std::size_tas
Arraycurrently also usesintas the indexing type. This seems tobe enough to prevent vectorisation in simple loops over
Matrixelements.