Skip to content

Reduce memory usage of squashoutput#1241

Merged
bendudson merged 2 commits intonextfrom
squash-memory
Sep 5, 2018
Merged

Reduce memory usage of squashoutput#1241
bendudson merged 2 commits intonextfrom
squash-memory

Conversation

@dschwoerer
Copy link
Contributor

Can help to avoid out of memory errors

bendudson
bendudson previously approved these changes Aug 30, 2018
@johnomotani
Copy link
Contributor

I think it would be good to add also a DataFile.sync() method to the parent DataFile class and include a docstring there. This seems to be our documentation convention for DataFile methods.

Copy link
Contributor

@johnomotani johnomotani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@bendudson bendudson merged commit d6202ee into next Sep 5, 2018
@bendudson bendudson deleted the squash-memory branch September 5, 2018 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants