Conversation
Previously, fup/fdown and Kup/Kdown fields were defined but not used. The inputs fin and Kin were copied to f and K before checking hasYupYdown(), but since yup_field and ydown_field are not copied in the Field3D assignment operator, the yup/ydown branch could never be used.
Member
|
I might even use |
bendudson
reviewed
Oct 29, 2018
src/mesh/fv_ops.cxx
Outdated
| } | ||
|
|
||
| if (!(K.hasYupYdown() && f.hasYupYdown())) { | ||
| if (!(Kin.hasYupYdown() && fin.hasYupYdown())) { |
Contributor
There was a problem hiding this comment.
Should this just use if (!use_yup_ydown) ?
bendudson
approved these changes
Oct 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, fup/fdown and Kup/Kdown fields were defined but not used. The inputs fin and Kin were copied to f and K before checking hasYupYdown(), but since yup_field and ydown_field are not copied in the Field3D assignment operator, the yup/ydown branch could never be used.
Second commit makes K/Kup/Kdown/f/fup/fdown into Field3D& references to avoid copies. Is this better or worse style?