Conversation
Member
Author
|
I don't know what Travis is complaining about here -- it looks like the push checks finished ok? |
bendudson
approved these changes
Nov 19, 2018
Contributor
bendudson
left a comment
bendudson
left a comment
There was a problem hiding this comment.
This code was not really used, and probably a better way can now be found with the new Region and difops template code.
This was referenced Nov 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1354 #1355
This does remove the experimental outer loop stuff. We might want to update that for the new
Regionstuff instead (or keep it in an experimental branch?)