Merged
Conversation
The "Ec" requests time in the current locale's alternate format -- this may or may not contain a timezone, however I guess now that we're using locales we should probably try to respect the locale's preferred format for things where possible.
bendudson
approved these changes
Dec 12, 2018
Contributor
bendudson
left a comment
bendudson
left a comment
There was a problem hiding this comment.
Failed on coverage test while installing packages
libopenmpi-dev : Depends: libhwloc-dev but it is not going to be installed
Member
Author
|
Testing this locally I now don't get the time zone at all and the original case that had two GMT doesn't seem repeatable so I'm closing this. |
Member
Author
|
I've now reproduced this (not enough cleaning beforehand). |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Ec" requests time in the current locale's alternate format -- this may or may not contain a timezone, however I guess now that we're using locales we should probably try to respect the locale's preferred format for things where possible.
Fixes #1428