Conversation
…it-final Conflicts: tests/integrated/test-boutcore/mms-ddz/runtest
We want to delete cobj ...
This makes sure that they can all be free'd before we call finalise. Further minor changes such as whitespace.
ZedThree
reviewed
Apr 4, 2019
Contributor
Author
|
The pr tests are all failing - however I doubt it is related to this PR ... |
ZedThree
approved these changes
Apr 9, 2019
Member
|
Thanks @dschwoerer, that's made the tests much nicer! valgrind is happier now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not particularly nice, to duplicating
__dealloc__- butfu.__dealloc__()cannot be called, and simply callingdel fudoesn't work ether, as long as there are other references.atexitshould ensure we are called rather late, to finalise. Any remaining references still need to be manually taken care of.