Skip to content

Bug fix, test and tidy SLEPc solver#1749

Merged
ZedThree merged 16 commits intonextfrom
slepc-fixes
Jun 14, 2019
Merged

Bug fix, test and tidy SLEPc solver#1749
ZedThree merged 16 commits intonextfrom
slepc-fixes

Conversation

@ZedThree
Copy link
Member

  • Fix bug in SLEPc solver (3ff8db9): use VecGetArrayRead instead of VecGetArray
  • Fix eigen-box example (default value dump_on_restart causing extra point in t_array, which was getting confused for half an eigenvalue)
  • Various improvements to the eigen-box visualisation script (pep8, graph titles, etc.)
  • New test for SLEPc solver: check eigenvalue of f * exp(t) is 0 + 1i
  • Use new Options interface in SLEPc
  • Various small improvements to SLEPc code, including clang-format

One for the wishlist: really separate eigen solvers from time solvers. Putting the eigenvalues in t_array, means they can only be accessed via the dump file, and not from with the library.

@ZedThree ZedThree added this to the BOUT-4.3 milestone Jun 13, 2019
@ZedThree ZedThree requested a review from d7919 June 13, 2019 17:12
bendudson
bendudson previously approved these changes Jun 13, 2019
Copy link
Contributor

@bendudson bendudson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! Thanks @ZedThree

@ZedThree ZedThree merged commit 9415fd7 into next Jun 14, 2019
@ZedThree ZedThree deleted the slepc-fixes branch June 14, 2019 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants