Conversation
o Renamed local mesh variables to a more readable format, similar to GlobalN* variables. o Extra point in Z removed, so LocalNz is the actual size of the domain, not ngz-1 o Increased BOUT_VERSION to 4, updated Python and IDL collect routines to handle lack of extra Z point in new outputs
Contributor
|
I'm in favor of merging, as it should not break any code (name has changed -> its easy to detect where ngz needs adjustment) If we wait to long, the branches might diverge ... and I am really looking forward to losing the extra point in z. Solves issue #19 |
Conflicts: examples/elm-pb/elm_pb.cxx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
o Renamed local mesh variables to a more readable
format, similar to GlobalN* variables.
o Extra point in Z removed, so LocalNz is the
actual size of the domain, not ngz-1
o Increased BOUT_VERSION to 4, updated Python and IDL collect
routines to handle lack of extra Z point in new outputs