Add clang-format bot command for pull requests#2032
Merged
Conversation
Simply have "/clang-format" as the first line in a comment to have clang-format automatically run over your PR!
dschwoerer
reviewed
Jul 3, 2020
| git clang-format-9 ${{ github.event.client_payload.pull_request.base.sha }} | ||
| git config --global user.name 'github-actions[bot]' | ||
| git config --global user.email '41898282+github-actions[bot]@users.noreply.github.com' | ||
| git commit -am "[clang-format-command] fixes" |
Contributor
There was a problem hiding this comment.
I just learned that there is the option --ignore-rev [1]
It might be worth to add it here 👍
[1] https://www.moxio.com/blog/43/ignoring-bulk-change-commits-with-git-blame
Member
Author
There was a problem hiding this comment.
As in, add the commit to a .git-blame-ignore-revs file? I guess that's possible, although it would require two commits. Another possibility would be to just periodically dump commits from github-actions[bot] to that file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simply have "/clang-format" as the first line in a comment to have clang-format automatically run over your PR! Commits are by
github-actions[bot]. It usesgit-clang-formatto just format the changes in the PR.I've tested this fairly extensively in a private repo, so I'm hoping it just works here. It needs to be merged into
masterand then it should Just Work. And it only took me this afternoon!