Small clang-tidy fixes for sundials solvers #2953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This type might be different between MPI implementations, warnings involving it being a specific typdef should mostly be ignored
We usually want to include `boutcomm` instead of `mpi` directly
Member
Author
|
The failing Fedora test is because this branch is missing the recent fix for |
dschwoerer
approved these changes
Aug 12, 2024
| * | ||
| **************************************************************************/ | ||
|
|
||
| #include "bout/build_config.hxx" |
Contributor
There was a problem hiding this comment.
Should we generally push to prefer build_defines.hxx?
Member
Author
There was a problem hiding this comment.
I have been switching to build_defines.hxx when we only need the preprocessor macro in a #if BOUT_HAS_FEATURE, because the misc-include-cleaner/IWYU complains about it -- alternatively, it's possible to add an IWYU pragma comment to make build_config.hxx the preferred header. Maybe that's better? Then we can basically forget about build_defines.hxx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.