Conversation
o By default, fields are now created with null yup() and ydown() fields.
Previously these pointed to the field, so could easily result
in the wrong values being calculated without error. Now if a parallel derivative
is taken an error will occur
o If CHECK >= 2 then yup() and ydown() are checked, and an exception thrown
indicating that they are not valid
o Modified some operators:
b0xGrad_dot_Grad - Here extra communications are currently needed
to set the yup() and ydown() fields of the velocity
fields. These values are not used in VDDX routines
so this doesn't need to be done.
Div_par - Does some manipulation of the yup() and ydown() fields
to introduce the factor of 1/B without communications.
o Removed some communications from elm-pb example. Mostly by removing factors of B0
which I don't think should be there
o Needed additional communicate on pe, pei o runtest wasn't deleting old output files, so passed if crashed before overwriting old outputs o Changed Y derivatives to C2 from C4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
o By default, fields are now created with null yup() and ydown() fields.
Previously these pointed to the field, so could easily result
in the wrong values being calculated without error. Now if a parallel derivative
is taken an error will occur
o If CHECK >= 2 then yup() and ydown() are checked, and an exception thrown
indicating that they are not valid
o Modified some operators:
b0xGrad_dot_Grad - Here extra communications are currently needed
to set the yup() and ydown() fields of the velocity
fields. These values are not used in VDDX routines
so this doesn't need to be done.
Div_par - Does some manipulation of the yup() and ydown() fields
to introduce the factor of 1/B without communications.
o Removed some communications from elm-pb example. Mostly by removing factors of B0
which I don't think should be there