Skip to content

Remove explicit use of MPI_COMM_WORLD#3217

Merged
ZedThree merged 1 commit into
nextfrom
remove-mpi_comm_world
Dec 1, 2025
Merged

Remove explicit use of MPI_COMM_WORLD#3217
ZedThree merged 1 commit into
nextfrom
remove-mpi_comm_world

Conversation

@ZedThree
Copy link
Copy Markdown
Member

@ZedThree ZedThree commented Dec 1, 2025

Fixes #3215

Copy link
Copy Markdown
Contributor

@dschwoerer dschwoerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

const int m = localmesh->LocalNx * localmesh->LocalNy * localmesh->LocalNz;
const int M = m * localmesh->getNXPE() * localmesh->getNYPE();
MatCreateAIJ(MPI_COMM_WORLD, m, m, M, M, 16, nullptr, 16, nullptr, &petscWeights);
MatCreateAIJ(BoutComm::get(), m, m, M, M, 16, nullptr, 16, nullptr, &petscWeights);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: no header providing "MatCreateAIJ" is directly included [misc-include-cleaner]

src/mesh/interpolation/hermite_spline_xz.cxx:28:

- #include <vector>
+ #include <petscmat.h>
+ #include <vector>

@ZedThree ZedThree merged commit 720e7b8 into next Dec 1, 2025
27 checks passed
@ZedThree ZedThree deleted the remove-mpi_comm_world branch December 1, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants