Consistent developer tooling; refactor formatting CI#3315
Conversation
`cppcoreguidelines-pro-bounds-avoid-unchecked-container-access` is not really suitable for numerical code
7d186da to
e1766e9
Compare
|
I'm going to make a separate PR into this one applying all the formatting rules across everything -- turns out we have a lot of trailing whitespace |
e1766e9 to
50015c2
Compare
50015c2 to
95f7f17
Compare
Maybe we should first try to reduce the number of open PRs, to avoid to many conflicts? |
|
I've expanded the docs on this further to make things clearer about how things work. I've also switched |
|
Just a heads up once this gets merged and people start using it: you can pass |
|
|
||
| .. code-block:: console | ||
|
|
||
| git clang-format next |
There was a problem hiding this comment.
git clang-format origin/next
next may be an old, stale local branch. But then, origin may also be there own fork, which may also be outdated ...
TL;DR:
CI will now fail on unformatted commits. Instead, run automatic formatting when you make commits:
clang-formatandclang-tidyare both essential tools for keeping the code clean and catching potential bugs, but the way they are currently run in CI is getting a bit annoying. Namely:clang-tidycomments end up in the wrong places.git-blame-ignore-revskeeps git blame clean but makes merge conflicts much more likely, requiring more merges to fix them + another round of CIclang-formaton dev machines and CI means formatting can flip-flop back and forthThis PR tries to fix these issues by:
.git-blame-ignore-revs