XZHermiteSpline: Move implementation_type to bout::details#3317
Merged
XZHermiteSpline: Move implementation_type to bout::details#3317
Conversation
Clang prints "internal linkage" warnings then fails to link when implementation_type is in an anonymous namespace. ChatGPT says "In C++, if a template argument involves a type/value with internal linkage, the resulting template specialization (and therefore its member functions) effectively become TU-local too. Moving implementation_type to bout::details namespace resolves the warnings and linker errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clang prints "internal linkage" warnings then fails to link when implementation_type is in an anonymous namespace.
ChatGPT says "In C++, if a template argument involves a type/value with internal linkage, the resulting template specialization (and therefore its member functions) effectively become TU-local too.
Moving implementation_type to bout::details namespace resolves the warnings and linker errors.