Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| template <typename T> | ||
| inline T toFieldAligned(const T& f, const std::string& region = "RGN_ALL") { | ||
| static_assert(bout::utils::is_Field_v<T>, "toFieldAligned only works on Fields"); | ||
| ASSERT3(f.getCoordinates() != nullptr); |
There was a problem hiding this comment.
warning: no header providing "ASSERT3" is directly included [misc-include-cleaner]
ASSERT3(f.getCoordinates() != nullptr);
^| @@ -68,7 +68,8 @@ public: | |||
| */ | |||
| Field2D(Mesh* localmesh = nullptr, CELL_LOC location_in = CELL_CENTRE, | |||
There was a problem hiding this comment.
warning: function 'Field2D::Field2D' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]
Field2D(Mesh* localmesh = nullptr, CELL_LOC location_in = CELL_CENTRE,
^Additional context
src/field/field2d.cxx:41: the definition seen here
Field2D::Field2D(Mesh* localmesh, CELL_LOC location_in, DirectionTypes directions_in,
^include/bout/field2d.hxx:68: differing parameters are named here: ('region'), in definition: ('UNUSED_regionID')
Field2D(Mesh* localmesh = nullptr, CELL_LOC location_in = CELL_CENTRE,
^| Field2D(Mesh* localmesh = nullptr, CELL_LOC location_in = CELL_CENTRE, | ||
| DirectionTypes directions_in = {YDirectionType::Standard, | ||
| ZDirectionType::Average}); | ||
| ZDirectionType::Average}, |
There was a problem hiding this comment.
warning: no header providing "ZDirectionType" is directly included [misc-include-cleaner]
ZDirectionType::Average},
^| DirectionTypes directions_in = {YDirectionType::Standard, | ||
| ZDirectionType::Average}); | ||
| ZDirectionType::Average}, | ||
| std::optional<size_t> region = {}); |
There was a problem hiding this comment.
warning: no header providing "std::optional" is directly included [misc-include-cleaner]
include/bout/field2d.hxx:27:
- class Field2D;
+ #include <optional>
+ class Field2D;| int yindex_in = -1, | ||
| DirectionTypes directions_in = {YDirectionType::Standard, | ||
| ZDirectionType::Standard}); | ||
| ZDirectionType::Standard}, |
There was a problem hiding this comment.
warning: no header providing "ZDirectionType" is directly included [misc-include-cleaner]
ZDirectionType::Standard},
^| Field3D::Field3D(Mesh* localmesh, CELL_LOC location_in, DirectionTypes directions_in) | ||
| : Field(localmesh, location_in, directions_in) { | ||
| Field3D::Field3D(Mesh* localmesh, CELL_LOC location_in, DirectionTypes directions_in, | ||
| std::optional<size_t> regionID) |
There was a problem hiding this comment.
warning: no header providing "std::optional" is directly included [misc-include-cleaner]
src/field/field3d.cxx:35:
- #include <utility>
+ #include <optional>
+ #include <utility>|
|
||
| FieldPerp::FieldPerp(Mesh* localmesh, CELL_LOC location_in, int yindex_in, | ||
| DirectionTypes directions) | ||
| DirectionTypes directions, std::optional<size_t> UNUSED(regionID)) |
There was a problem hiding this comment.
warning: no header providing "DirectionTypes" is directly included [misc-include-cleaner]
DirectionTypes directions, std::optional<size_t> UNUSED(regionID))
^|
|
||
| FieldPerp::FieldPerp(Mesh* localmesh, CELL_LOC location_in, int yindex_in, | ||
| DirectionTypes directions) | ||
| DirectionTypes directions, std::optional<size_t> UNUSED(regionID)) |
There was a problem hiding this comment.
warning: no header providing "UNUSED" is directly included [misc-include-cleaner]
src/field/fieldperp.cxx:25:
- #include <bout/boutcomm.hxx>
+ #include "bout/unused.hxx"
+ #include <bout/boutcomm.hxx>
| @@ -68,7 +68,8 @@ public: | |||
| */ | |||
| Field2D(Mesh* localmesh = nullptr, CELL_LOC location_in = CELL_CENTRE, | |||
There was a problem hiding this comment.
warning: function 'Field2D::Field2D' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]
Field2D(Mesh* localmesh = nullptr, CELL_LOC location_in = CELL_CENTRE,
^Additional context
src/field/field2d.cxx:43: the definition seen here
Field2D::Field2D(Mesh* localmesh, CELL_LOC location_in, DirectionTypes directions_in,
^include/bout/field2d.hxx:68: differing parameters are named here: ('region'), in definition: ('UNUSED_regionID')
Field2D(Mesh* localmesh = nullptr, CELL_LOC location_in = CELL_CENTRE,
^
|
At some point we should look into using scikit-build-core to replace the custom backend |
2 participants
Mostly improvements to the boutpp python interface, and some minor other things.