Skip to content

Removing IS_MYPROC#500

Merged
bendudson merged 2 commits intoboutproject:nextfrom
loeiten:rm_IS_MYPROC
Mar 28, 2017
Merged

Removing IS_MYPROC#500
bendudson merged 2 commits intoboutproject:nextfrom
loeiten:rm_IS_MYPROC

Conversation

@loeiten
Copy link
Member

@loeiten loeiten commented Mar 27, 2017

This is not used anywhere, and is also wrong, as mentioned in #226.

@dschwoerer
Copy link
Contributor

strictly speaking this changes the interface of bout.
Shouldn't we deprecate it, and drop it in 5.0?

@loeiten
Copy link
Member Author

loeiten commented Mar 27, 2017

I guess this would be the proper way of doing it :).
However, it is a private class member which is wrong and not in use.
If anyone wants to use it, then strictly speaking, the changes will have to wait to 5.0 anyway.
Therefore, my opinion is that it is fine to merge at the current time.

@dschwoerer
Copy link
Contributor

I didn't remember that it is private ...

@bendudson bendudson merged commit 236e5ca into boutproject:next Mar 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants