Replace msg_stack with TRACE everywhere#575
Merged
Conversation
Currently can't easily replace any instances where string formatting is required as not supported by TRACE yet. Also not changing nested calls yet as more complicated to ensure correct scope of TRACE without effecting scope of variables etc.
This replaces msg_stack calls that require formatting.
This provides an example of how to use the TRACE formatting capability with a ternary conditional to allow different TRACE messages depending on routine arguments.
This was referenced Jun 9, 2017
bendudson
approved these changes
Jun 12, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces all usage of
msg_stack.push/popwith theTRACEmacro.Not only does this remove a lot of explicit
#ifdef CHECKlines it also fixes a number of minor bugs. These mostly arose from eitherpushorpopcalls that had unmatchedCHECKguarding (e.g. one in a#ifdef CHECKand the other not),returnstatements after apushbut before apopand some nesting issues.