Merged
Conversation
Member
|
Whilst it's requested that there's no Fortran in BOUT++ I think this doesn't mean a Fortran project can't use the BOUT++ library (with appropriate wrapping), so the Fortran compiler flag could perhaps be useful for people who are trying to do this -- although I may be wrong! |
Contributor
|
Sadly Fortran is sometimes needed, for example coupling to EIRENE. Whilst no Fortran should go in the core code, coupling to external libraries may be necessary. |
Contributor
Author
|
I am quite sure nobody used this. Further, $fc is set to none. Rather sure, you cannot compile EIRENE with this 👍 If I implement bout's configure to look for a fortran compiler, I can add this again, also providing apropriate flags ... |
bendudson
approved these changes
Jul 6, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CONTRIBUTION.mdhints that the use of Fortran is not directly preferred (i.e. to be never used).bin/bout-configstill provides a fortran mpi compiler :D