Skip to content

fix typos in bout-config#595

Merged
bendudson merged 2 commits intoboutproject:nextfrom
dschwoerer:fix_typos
Jul 6, 2017
Merged

fix typos in bout-config#595
bendudson merged 2 commits intoboutproject:nextfrom
dschwoerer:fix_typos

Conversation

@dschwoerer
Copy link
Contributor

CONTRIBUTION.md hints that the use of Fortran is not directly preferred (i.e. to be never used).
bin/bout-config still provides a fortran mpi compiler :D

@d7919
Copy link
Member

d7919 commented Jul 4, 2017

Whilst it's requested that there's no Fortran in BOUT++ I think this doesn't mean a Fortran project can't use the BOUT++ library (with appropriate wrapping), so the Fortran compiler flag could perhaps be useful for people who are trying to do this -- although I may be wrong!

@bendudson
Copy link
Contributor

Sadly Fortran is sometimes needed, for example coupling to EIRENE. Whilst no Fortran should go in the core code, coupling to external libraries may be necessary.

@dschwoerer
Copy link
Contributor Author

I am quite sure nobody used this.
Otherwise --fc would not return an error that it is an unknown option.

Further, $fc is set to none. Rather sure, you cannot compile EIRENE with this 👍

If I implement bout's configure to look for a fortran compiler, I can add this again, also providing apropriate flags ...

@bendudson bendudson merged commit e279e93 into boutproject:next Jul 6, 2017
@dschwoerer dschwoerer deleted the fix_typos branch February 27, 2018 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants