Adding missing __setitem__ and keys() functions#728
Merged
Conversation
Because the __enter__ function returns the implementation, using with DataFile(..) as f: ... f["somevar"] = a would not work; the implementations did not have __setitem__ methods. The DataFile class did not have a keys() function, though the implementations did. This makes them consistent by adding a keys() function to DataFile. This does the same as list(), but is more consistent with the python standard containers.
ZedThree
approved these changes
Oct 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the enter function returns the implementation,
using
with DataFile(..) as f:
...
f["somevar"] = a
would not work; the implementations did not have setitem methods.
The DataFile class did not have a keys() function, though the
implementations did. This makes them consistent by adding a keys()
function to DataFile. This does the same as list(), but is more
consistent with the python standard containers.