Conversation
min/max return BoutReals -- no need to use helper function
d7919
reviewed
Dec 8, 2017
tests/unit/field/test_field2d.cxx
Outdated
| } | ||
|
|
||
| TEST_F(Field2DTest, CopyCheckFieldmesh) { | ||
| int test_nx = 2; |
Member
There was a problem hiding this comment.
I assume these values are different from the "global" mesh so we're testing that it's definitely using fieldmesh? Would it be more robust to explicitly define these in terms of some difference from the global mesh (e.g. test_nx = global_nx + 2 or similar)?
Member
Author
There was a problem hiding this comment.
Yes, that would probably make it more obvious what's happening, thanks
bendudson
approved these changes
Dec 12, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds some simple tests for Field2D/Field3D:
Also adds
UNUSEDto some arguments for the newsetAttributesmethods inDataFormat