Conversation
bendudson
previously approved these changes
Jan 16, 2018
Member
|
I'm in favour of making the gcc-7 job turning on all the warnings, and just compile + unit tests |
ZedThree
approved these changes
Jan 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the Travis build jobs is used to check support for upcoming compiler changes -- this was done with gcc-6 but this PR changes this to gcc-7 as this is now available.
May want to consider enabling all compiler warning flags here as this is one way we can get early notice/make use of new/emerging checks.