Ensure Matrix/Tensor data block unique before modification#894
Merged
Ensure Matrix/Tensor data block unique before modification#894
Conversation
Adds unit tests for this feature Adds ASSERT1 checks in constructor to make sure passed sizes are non-zero Note we could ensure the data block is unique in the constructor, but instead I've currently added this just to the routines which could change values stored in the data block.
Whilst we can't index a Matrix/Tensor with a dimension of 0 it can be helpful to still create such objects (to avoid handling special cases), it is just an error to then index them.
ZedThree
approved these changes
Feb 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds unit tests for this feature (thanks @ZedThree )
Adds ASSERT1 checks in constructor to make sure passed sizes are(removed as actually want to allow creating objects with 0 dimension size, just an error to then try to index them).non-zero
Note we could ensure the data block is unique in the constructor, but
instead I've currently added this just to the routines which could
change values stored in the data block.