Skip to content

Add bout-upgrader tool #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ZedThree merged 82 commits into from
Sep 30, 2024
Merged

Add bout-upgrader tool #111

ZedThree merged 82 commits into from
Sep 30, 2024

Conversation

@ZedThree
Copy link
Member

@ZedThree ZedThree commented Sep 12, 2024

v4 and v5 upgrader scripts moved from bout-dev repo and into top-level package here. Converted to use a single entry point `bout-upgrader

ZedThree and others added 30 commits September 11, 2024 15:57
@ZedThree
Add tool for updating v4 factory uses to v5 style
d871cc1
@ZedThree
Add LaplaceXZ to factory-upgrader helper script
ef2eae8
@ZedThree
Add InvertPar to factory-upgrader helper script
1a3ef9b
@ZedThree
Catch static variables with zero initialisation in factory upgrader
43ecd30
@ZedThree
Add Mesh to factory updater
b50ca68
@ZedThree
Add InterpolationFactory to factory upgrader
5d3e07b
@ZedThree
Add format-upgrader to replace printf formats with fmt formats
0db1788
@ZedThree
Make format upgrader fix uses of {:s} with std::string::c_str
b652493
@ZedThree
Add formats with width specifier to v5 format fixer
4dd3a7d
@ZedThree
Fix all BoutException calls in library
d1f83bc
@ZedThree
Fix uses of toString().c_str() with formatting
59727bb
@ZedThree
Add updater for Interpolation -> XZInterpolation types
9da6d86
@ZedThree
Add input file upgrader for v4 -> v5
d9a2548 
Currently just "canonicalises" input files and adds "bout_version" option
@ZedThree
Add input replacements for paralleltransform changes
b8836a6
@ZedThree
Fix typo in input file upgrader
8dc28dd
@ZedThree
Add 4to5 macro updater script
e4efa55
@ZedThree
Move bout::version::revision into standalone file
af193d5 
Makefile-build system now also configures this file to include the
commit from configure-time, so that bout::version::revision will
always have a meaningful value even if -DBOUT_REVISION is not passed
on command line
@ZedThree
Write comments using '#' in BoutOptions
720ac0d 
Canonical form for v5
@ZedThree
Fix uncompiled parts of #ifdef blocks in macro upgrader
cec0075
@ZedThree
Add renamed feature macros to bout-v5-macro-upgrader
435e885
@ZedThree
Fix a couple of uses of renamed macros
b0f6e50
@ZedThree
Consider underscores as word boundaries when updating macros
2ee94f8
@ZedThree
Fix bug with default file format when using legacy netcdf
e5764ed
@ZedThree
Add fixer for change of factory create method name
dd0b505
@ZedThree
Add warning in upgrader if factory arguments have changed
a58540d
@johnomotani @ZedThree
Option to update values in bout-v5-input-file-upgrader.py
5f322fd
@johnomotani @ZedThree
Deprecate fft_measure option
d24b391 
Only keep fft_measurement_flag.
@johnomotani @ZedThree
Handle bool-like expressions in the same way as BOUT++
4bf3484
@ZedThree
Add tool to upgrade legacy models
363e1c3
@ZedThree
Catch (some) invalid names in physics model upgrader
8c8851b
ZedThree and others added 24 commits September 11, 2024 15:57
@ZedThree
Add some comments to physics model upgrader
299f0a4 
[skip ci]
@ZedThree
Remove some now obsolete input options for DataFile
8c9fe1b
@ZedThree
Add tool to move headers under include/bout and fix #includes
6f1585c 
Replaces similar bash tool
@bendudson @ZedThree
Update bin/bout-v5-header-upgrader.py
f83cadb
@ZedThree
Pull out duplicated code from upgrader scripts
050131a
@ZedThree
Move upgrader scripts from BOUT-dev repo to boututils
b3547d7
@ZedThree
Add upgrader scripts as subcommands of top-level bout-upgrader
7fe4f04
@ZedThree
Move import of boutdata into function to avoid circular dependency
cf58eca
@ZedThree
Apply black
050437e
@ZedThree
Move upgrader script to own package
1ac8499
@ZedThree
Remove execute permissions from individual upgrader modules
960b69b
@ZedThree
Remove unneeded function
2f8df50
@ZedThree
Sort headers
5ac848b
@ZedThree
Replace .format with f-strings
1e38d87
@ZedThree
Remove default open flags
c835b75
@ZedThree
Use generator in place of tuple
b728c86
@ZedThree
Group v5 upgrade subcommands
24a1386
@ZedThree
Add version argument to bout-upgrader
f948fc2
@ZedThree
Add tool to help with updating files from v3 to v4
14c7dc3
@ZedThree
Use mesh->coordinates() instead of coords in 3to4
5f3d19e 
Slightly uglier, but resulting file doesn't need additional lines
manually adding
@ZedThree
Enable bout_3to4 to check 2D subscripts
5bbe434
@loeiten @ZedThree
Added ng@ -> LocalN@ replacement
3f35847 
As a sidenote, the following replacements would be handy, but was not
implemented in this commit

    a^b -> pow(a,b)
    Field3D.max(bool_or_NULL) -> max(Field3D, bool_or_NULL
@loeiten @ZedThree
Changed ngz to warning, added more warnings
4969437
@ZedThree
Move bout_3to4 into boutupgrader structure
b66b192
@ZedThree ZedThree mentioned this pull request Sep 12, 2024
Closed
@ZedThree ZedThree merged commit bfd3ca0 into master Sep 30, 2024
@ZedThree ZedThree deleted the upgrader-script branch September 30, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ZedThree @johnomotani @bendudson @loeiten