Merged
Conversation
|
Verified that @aptxkid has signed the CLA. Thanks for the pull request! |
test/functional/job_configs.py
Outdated
Contributor
There was a problem hiding this comment.
Why is this config empty?
Contributor
Author
There was a problem hiding this comment.
This PR is more about the 'how' to have platform specific commands in functional test configs than 'what' exactly those commands would be. I am rewriting those shell commands in batch, but it's gonna take a little while. This is also good for keep each PR small. What you think?
Contributor
Author
There was a problem hiding this comment.
@josephharrington I have one last job config to rewrite anyway. I will update the PR with all batch commands under key 'nt'.
Contributor
There was a problem hiding this comment.
Sounds good. That's what I figured but I wanted to make sure.
Before this commit, job_configs has three configs that only works in POSIX systems. This commit makes it so that each config contains a dictionary pointing to different real configs for different underlying platform so running the functional test on Windows will run Windows command and on Mac will run POSIX commands.
Contributor
|
👍 |
uvdn7
force-pushed
the
cross-platform-functional
branch
from
0738e44 to
4f1f548
Compare
uvdn7
added a commit
that referenced
this pull request
Jun 24, 2015
Make job_configs for multiple platforms
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit, job_configs has three configs that only works in POSIX systems. This commit makes it so that each config contains a dictionary pointing to different real configs for different underlying platform so running the functional test on Windows will run Windows command and on Mac will run POSIX commands.