Merged
Conversation
This fixes currently failing lint jobs. I also regenerated the pylintrc file (`pylint --generate-rcfile`) and added back some of our custom rule ignores. Pylint 1.4.2 has an incompatibility with the newest version of one of its dependencies (astroid). This has started causing our lint jobs to fail with a bunch of errors that look like: ``` E: 37, 8: Undefined variable 'self' (undefined-variable) ``` Since we have only specified exact versions of our dependencies in requirements.txt (and not the exact versions of dependencies' dependencies, etc.) it's still possible for third party libraries to break something without a change on our side. We should switch over to using peep (https://pypi.python.org/pypi/peep) or something similar.
|
Verified that @josephharrington has signed the CLA. Thanks for the pull request! |
Contributor
Author
There was a problem hiding this comment.
Most additions and changes in this file are just new defaults from pylint --generate-rcfile. The only changes I made to the new default rcfile were to these disable= rules and some of the flags we had already changed (e.g., colorized output, no full reports).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes currently failing lint jobs. I also regenerated the
pylintrc file (
pylint --generate-rcfile) and added back some of ourcustom rule ignores.
Pylint 1.4.2 has an incompatibility with the newest version of one of
its dependencies (astroid). This has started causing our lint jobs to
fail with a bunch of errors that look like:
Since we have only specified exact versions of our dependencies in
requirements.txt (and not the exact versions of dependencies'
dependencies, etc.) it's still possible for third party libraries to
break something without a change on our side.
We should switch over to using peep
(https://pypi.python.org/pypi/peep) or something similar.