feat(i18n): add options field#478
Merged
mergify[bot] merged 5 commits intobox:masterfrom May 11, 2020
Merged
Conversation
jstoffan
reviewed
May 7, 2020
jstoffan
reviewed
May 8, 2020
Collaborator
jstoffan
left a comment
jstoffan
left a comment
There was a problem hiding this comment.
Approach seems good, given the limitations we're dealing with.
jstoffan
reviewed
May 8, 2020
* Add options field that can be passed into the instance. These options then will be passed to the annotator in Preview SDK.
* Add language field in type
* PR Feedback
* Add intl wrapper object for options
jstoffan
approved these changes
May 11, 2020
ConradJChan
reviewed
May 11, 2020
| * [constructor] | ||
| * | ||
| * @param {Object} viewerOptions - Viewer-specific annotator options | ||
| * @param {AnnotationsOptions } options - options passed to the annotations instance |
Contributor
There was a problem hiding this comment.
nit: space between { and AnnotationsOptions
| }); | ||
|
|
||
| describe('getOptions', () => { | ||
| it.each([undefined, { intl: { messages: { test: 'Hello' } } }])( |
Contributor
There was a problem hiding this comment.
Should this be test rather than it?
ConradJChan
approved these changes
May 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
determineAnnotator. These options will then be passed to the annotator configs in Preview SDK and use the currentintlframework