feat(delete): add delete annotation flow#486
Merged
mergify[bot] merged 6 commits intobox:masterfrom May 19, 2020
Merged
Conversation
Collaborator
mickr
commented
May 15, 2020
mickr
commented
- Add reducer cases to remove annotaiton from store
- Add new delete action
- Add event listener for delete event from ui-elements.
- add tests
* Add reducer cases to remove annotaiton from store * Add new delete action * Add event listener for delete event from ui-elements. * add tests
ConradJChan
reviewed
May 15, 2020
jstoffan
reviewed
May 15, 2020
* PR Feedback
jstoffan
reviewed
May 15, 2020
* Rename actions and methods to removeAnnotation
ConradJChan
reviewed
May 15, 2020
ConradJChan
reviewed
May 15, 2020
* Rename actions and methods to removeAnnotation
ConradJChan
previously approved these changes
May 18, 2020
Contributor
ConradJChan
left a comment
ConradJChan
left a comment
There was a problem hiding this comment.
Yeah I was just trying to jam it into the existing naming conventions, but it doesn't quite work. Maybe annotations_remove is better but the outgoing events should be past tense, like annotations_[created|deleted|updated]?
* PR Feedback
jstoffan
approved these changes
May 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.