feat(region): Retain annotation message between pages#498
Merged
mergify[bot] merged 3 commits intobox:masterfrom May 27, 2020
Merged
feat(region): Retain annotation message between pages#498mergify[bot] merged 3 commits intobox:masterfrom
mergify[bot] merged 3 commits intobox:masterfrom
Conversation
jstoffan
reviewed
May 23, 2020
ConradJChan
reviewed
May 26, 2020
mingzexiao6
force-pushed
the
retain-message
branch
5 times, most recently
from
208b4c9 to
c28d0c7
Compare
jstoffan
reviewed
May 27, 2020
Collaborator
jstoffan
left a comment
jstoffan
left a comment
There was a problem hiding this comment.
It seems like more fundamental changes to the reducer would simplify this a lot.
mingzexiao6
force-pushed
the
retain-message
branch
from
c28d0c7 to
4cae19c
Compare
jstoffan
reviewed
May 27, 2020
Collaborator
jstoffan
left a comment
jstoffan
left a comment
There was a problem hiding this comment.
The new approach is nice refinement.
jstoffan
approved these changes
May 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.