chore(highlights): Move HighlightListener to textLayer#585
Merged
mergify[bot] merged 6 commits intobox:masterfrom Sep 10, 2020
Merged
chore(highlights): Move HighlightListener to textLayer#585mergify[bot] merged 6 commits intobox:masterfrom
mergify[bot] merged 6 commits intobox:masterfrom
Conversation
jstoffan
reviewed
Sep 9, 2020
ConradJChan
force-pushed
the
move-highlight-listener
branch
2 times, most recently
from
6cb9799 to
10464d6
Compare
mingzexiao6
reviewed
Sep 10, 2020
ConradJChan
force-pushed
the
move-highlight-listener
branch
from
50b97d3 to
1c3801b
Compare
jstoffan
reviewed
Sep 10, 2020
jstoffan
approved these changes
Sep 10, 2020
mingzexiao6
approved these changes
Sep 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out the
HighlightListenerlogic around mouse up/down events into a per pageHighlightCreatorManagerthat attaches the mouse up/down event listeners to the text layer itselfTODO