feat(mode): Remove toggle logic#590
Merged
mergify[bot] merged 2 commits intobox:masterfrom Sep 15, 2020
Merged
Conversation
jstoffan
reviewed
Sep 14, 2020
| builder.addCase(toggleAnnotationModeAction, (state, { payload: mode }: { payload: Mode }) => | ||
| state === mode ? Mode.NONE : mode, | ||
| ), | ||
| builder.addCase(toggleAnnotationModeAction, (state, { payload: mode }: { payload: Mode }) => mode), |
Collaborator
There was a problem hiding this comment.
This seems a bit risky, since the Preview SDK and Annotations SDK may not be released at the same time. Should we create a setAnnotationMode event or method, instead?
Contributor
Author
There was a problem hiding this comment.
Preview SDK changes are behind the discoverability feature flip, so Annotations SDK will release first, which is not risky, because all the usages in Preview SDK is already using toggleAnnotationMode as setAnnotationMode.
jstoffan
approved these changes
Sep 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FSM in Preview SDK maintains the source of truth. So there is no need to have extra logic for setting mode in annotations.