Skip to content

feat(highlight): Show popup for multi-page selection#599

Merged
mergify[bot] merged 6 commits intobox:masterfrom
mingzexiao6:highlight-cross-page
Sep 24, 2020
Merged

feat(highlight): Show popup for multi-page selection#599
mergify[bot] merged 6 commits intobox:masterfrom
mingzexiao6:highlight-cross-page

Conversation

@mingzexiao6
Copy link
Contributor

@mingzexiao6 mingzexiao6 commented Sep 22, 2020

  • Unit test
  • Cross-browser testing

Up-down selection:
image

Down-up selection:
image

In explicit highlight mode:
image

@mingzexiao6 mingzexiao6 requested a review from a team as a code owner September 22, 2020 18:44
@mingzexiao6 mingzexiao6 marked this pull request as draft September 22, 2020 18:44
@mingzexiao6 mingzexiao6 marked this pull request as ready for review September 23, 2020 00:18
@mergify mergify bot merged commit 0ff04b1 into box:master Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants