fix(popup): Use reference id instead of shape#629
Merged
ConradJChan merged 6 commits intobox:masterfrom Nov 2, 2020
Merged
Conversation
jstoffan
reviewed
Oct 27, 2020
ConradJChan
force-pushed
the
fix-region-creation-resize
branch
from
bb7a5af to
58b1e30
Compare
ConradJChan
force-pushed
the
fix-region-creation-resize
branch
from
58b1e30 to
f292d34
Compare
ConradJChan
changed the title
jstoffan
reviewed
Oct 28, 2020
jstoffan
reviewed
Oct 28, 2020
jstoffan
reviewed
Oct 28, 2020
jstoffan
reviewed
Oct 28, 2020
jstoffan
previously approved these changes
Oct 28, 2020
ConradJChan
force-pushed
the
fix-region-creation-resize
branch
from
a139b13 to
7dedb6a
Compare
jstoffan
reviewed
Oct 29, 2020
jstoffan
reviewed
Oct 29, 2020
added 2 commits
October 29, 2020 16:05
mingzexiao6
approved these changes
Oct 30, 2020
jstoffan
approved these changes
Oct 30, 2020
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the strategy for communicating where the staged annotation is from the creator to the popup layer from storing a reference shape in redux to a reference id which the popup layer uses instead to query the actual DOM element -- which allows PopperJS to do what it does best and updates the popup to follow the element as it resizes and shifts based on zoom or window resize actions
TODO: