feat(drawing): Create staged drawing#640
Merged
ConradJChan merged 7 commits intobox:masterfrom Dec 7, 2020
Merged
Conversation
mingzexiao6
reviewed
Nov 30, 2020
jstoffan
reviewed
Nov 30, 2020
| renderStep(renderPath); | ||
| } | ||
|
|
||
| return () => { |
Collaborator
There was a problem hiding this comment.
Can we make a reusable hook that handles the management of the RAF callback/handle?
Contributor
Author
There was a problem hiding this comment.
Will do in a separate PR
cweeii
reviewed
Nov 30, 2020
ChenCodes
reviewed
Nov 30, 2020
ChenCodes
reviewed
Nov 30, 2020
ChenCodes
reviewed
Nov 30, 2020
ConradJChan
force-pushed
the
create-drawing-component
branch
from
6beb0b9 to
b0cb1e3
Compare
jstoffan
reviewed
Dec 1, 2020
ConradJChan
force-pushed
the
create-drawing-component
branch
from
b0cb1e3 to
dfeabba
Compare
jstoffan
reviewed
Dec 3, 2020
Collaborator
jstoffan
left a comment
jstoffan
left a comment
There was a problem hiding this comment.
Looks good to me. Nice job.
mingzexiao6
reviewed
Dec 3, 2020
mingzexiao6
reviewed
Dec 4, 2020
jstoffan
reviewed
Dec 4, 2020
src/components/PointerCapture/__tests__/PointerCapture-test.tsx
Outdated
Show resolved
Hide resolved
src/components/PointerCapture/__tests__/PointerCapture-test.tsx
Outdated
Show resolved
Hide resolved
src/components/PointerCapture/__tests__/PointerCapture-test.tsx
Outdated
Show resolved
Hide resolved
src/components/PointerCapture/__tests__/PointerCapture-test.tsx
Outdated
Show resolved
Hide resolved
src/components/PointerCapture/__tests__/PointerCapture-test.tsx
Outdated
Show resolved
Hide resolved
mingzexiao6
approved these changes
Dec 7, 2020
ChenCodes
approved these changes
Dec 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: