New: Setup selenium functional UI framework by pramodsum · Pull Request #158 · box/box-annotations

pramodsum · 2018-04-02T22:06:39Z

Set up express app to generate annotator tokens and test browsers
Update travis.yml w/ saucelabs config
Allowing concurrent testing w/ file ids in env variables

- Set up express app to generate annotator tokens and test browsers - Update travis.yml w/ saucelabs config - Allowing concurrent testing w/ file ids in env variables

boxcla · 2018-04-02T22:06:42Z

Verified that @pramodsum has signed the CLA. Thanks for the pull request!

JustinHoldstock · 2018-04-04T19:40:32Z

.travis.yml

-  - /^greenkeeper/.*$/
+    email: false
+        # recipients:
+        #     - spramod@box.com


Did you mean to leave this commented section?

JustinHoldstock · 2018-04-04T19:41:33Z

codecept.conf.js

+const isLocalBuild = typeof SAUCE_USERNAME === 'undefined';
+
+if (isLocalBuild) {
+    // // Config to test using the Chrome emulator


remove commented code?

JustinHoldstock · 2018-04-04T19:42:27Z

codecept.conf.js

+    helperObj.WebDriverIO = commonConfigObj;
+} else {
+    // Common saucelab config
+    const sauceObj = {


Can this be moved to a higher level variable, or does it need to be created on each run of this code?

JustinHoldstock · 2018-04-04T19:43:17Z

functional-tests/helpers/cleanup.js

@@ -0,0 +1,47 @@
+/* eslint-disable func-names */


AFAIK you can bundle all of your eslint-disables into one statement.

jeremypress · 2018-04-11T19:58:21Z

functional-tests/app.js

+
+// Set up SDK & client
+const sdk = new BoxSDK({
+    clientID: 'l20yq2uyg3y8vl27rvw67m8s0ryo9mrz',


Make this an env var?

jeremypress · 2018-04-11T19:59:22Z

functional-tests/views/index.pug

@@ -0,0 +1,32 @@
+<!DOCTYPE html>


Why is this a pug file?

since we're setting up the preview expiring embed using an express app, it uses pug to pass in the variables rather than a straight html file

jeremypress · 2018-04-11T19:59:40Z

functional-tests/views/index.pug

+    <meta charset="UTF-8">
+    link(rel="stylesheet" href='annotations.css')
+    script(src='annotations.js')
+    link(rel="stylesheet" href='https://cdn01.boxcdn.net/platform/preview/1.37.0/en-US/preview.css')


How are you planning on keeping this up to date?

Since Preview shouldn't affect annotations anymore, using an older version of preview shouldn't make a difference. The only reason I could see to update this regularly would be if there's drastic changes to how Preview and Annotations interact.

Maybe you can make this an env variable just incase?

also will have to update this after your css class gets added into preview.

the CSS change is in the annotations codebase so it shouldn't affect the preview version

jeremypress · 2018-04-11T20:00:13Z

src/Annotator.js

@@ -149,6 +150,7 @@ class Annotator extends EventEmitter {
            .then(() => {


Separate any actual changes to the lib as a separate commit

Moved to this PR #167

jeremypress · 2018-04-11T20:46:43Z

package.json

    "watch": "yarn install && BABEL_ENV=dev NODE_ENV=dev ./node_modules/.bin/webpack --watch --progress --colors --config build/webpack.config.js",
    "test": "yarn install && NODE_ENV=test ./node_modules/.bin/karma start build/karma.conf.js",
    "debug": "yarn install && NODE_ENV=test ./node_modules/.bin/karma start build/karma.conf.js --no-single-run --auto-watch",
+    "setup-travis": "cd functional-tests && yarn install && node app.js",


does this need to point to the functional test folder as well? functional_tests/app.js

it cd's into the functional test folder so it's fine

DanDeMicco · 2018-04-12T22:16:31Z

functional-tests/helpers/actor.js

@@ -0,0 +1 @@
+module.exports = actor;


is this file needed?

DanDeMicco · 2018-04-12T22:17:41Z

codecept.conf.js

+const commonConfigObj = {
+    browser: BROWSER_NAME,
+    url: 'http://localhost:8080',
+    smartWait: DEFAULT_WAIT_TIME,


You should remove smartWait. Jeremy and I found it to be buggy

jeremypress · 2018-04-12T22:13:15Z

.travis.yml

+- name: Android
+  if: type = cron
+jobs:
+  include:


Check out Daniel's recent commit where he cleaned this up.

jeremypress · 2018-04-12T22:30:52Z

functional-tests/views/index.pug

+    <meta charset="UTF-8">
+    link(rel="stylesheet" href='annotations.css')
+    script(src='annotations.js')
+    link(rel="stylesheet" href='https://cdn01.boxcdn.net/platform/preview/1.37.0/en-US/preview.css')


also will have to update this after your css class gets added into preview.

Sumedha Pramod added 2 commits April 2, 2018 14:52

New: Add functional UI tests

e0d9269

- Set up express app to generate annotator tokens and test browsers - Update travis.yml w/ saucelabs config - Allowing concurrent testing w/ file ids in env variables

Chore: Add functional tests for point annotations

d400e31

pramodsum force-pushed the func branch from d551d2f to fac29f7 Compare April 2, 2018 22:11

Chore: Only run tests on cron jobs

067e118

pramodsum force-pushed the func branch from fac29f7 to 067e118 Compare April 2, 2018 22:14

JustinHoldstock reviewed Apr 4, 2018

View reviewed changes

pramodsum changed the title ~~New: Add functional UI tests~~ New: Setup selenium functional UI framework Apr 11, 2018

pramodsum and others added 5 commits April 11, 2018 11:40

Merge branch 'master' into func

e878813

Chore: Cleanup comments

fadb890

Chore: Only run enabled functional-tests

992c929

Chore: Run tests using all files in functional-tests/tests/ folder

86ce6c6

Chore: Send travis alert emails to preview-alerts@box.com

5c84330

jeremypress reviewed Apr 11, 2018

View reviewed changes

pramodsum and others added 3 commits April 11, 2018 19:02

Merge branch 'master' into func

f7cf91d

Chore: Moving clientID to an env variable

0e80b3d

Chore: Remove code changes from PR

765e0e5

pramodsum force-pushed the func branch from cf13fb7 to 765e0e5 Compare April 12, 2018 02:11

pramodsum mentioned this pull request Apr 12, 2018

New: Add plain highlight functional tests #168

Merged

Merge branch 'master' into func

9efb682

DanDeMicco reviewed Apr 12, 2018

View reviewed changes

functional-tests/helpers/actor.js Outdated

@@ -0,0 +1 @@

module.exports = actor;

Copy link

Contributor

DanDeMicco Apr 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this file needed?

DanDeMicco reviewed Apr 12, 2018

View reviewed changes

Chore: Cleanup

400de15

jeremypress approved these changes Apr 12, 2018

View reviewed changes

Sumedha Pramod added 2 commits April 12, 2018 15:46

Chore: Remove stages from travis.yml

e6dd497

Chore: Update functional test README

2f50871

pramodsum force-pushed the func branch from 06beae7 to 2f50871 Compare April 12, 2018 23:18

pramodsum merged commit db9a320 into box:master Apr 12, 2018

		@@ -149,6 +150,7 @@ class Annotator extends EventEmitter {
		.then(() => {

Conversation

pramodsum commented Apr 2, 2018

Uh oh!

boxcla commented Apr 2, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DanDeMicco Apr 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

DanDeMicco Apr 12, 2018 •

edited

Loading