Chore: Prefix imported styles to avoid leaking#165
Merged
jeremypress merged 3 commits intobox:masterfrom Apr 13, 2018
jeremypress:css
Merged
Chore: Prefix imported styles to avoid leaking#165jeremypress merged 3 commits intobox:masterfrom jeremypress:css
jeremypress merged 3 commits intobox:masterfrom
jeremypress:css
Conversation
|
Verified that @jeremypress has signed the CLA. Thanks for the pull request! |
Author
|
@pramodsum could we somehow prefix all base annotations divs with .ba? Then we could avoid relying on Preview's selector. Also, are you aware of us overriding any BRUI styles in later annotations CSS? I'll need to check that those are ok. |
Contributor
|
I think we can prefix all annotation dialog/thread related divs but the tricky part becomes prefixing some preview divs such as the mode buttons in the header. Those have to remain as |
Author
|
Ok we can leave this as bp-container then since all annotations stuff that needs these styles will live inside of here. |
JustinHoldstock
approved these changes
Apr 11, 2018
pramodsum
approved these changes
Apr 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.