Fix: firefox dialog collapse on mouseout#175
Merged
DanDeMicco merged 2 commits intobox:masterfrom Apr 17, 2018
Merged
Conversation
|
Verified that @DanDeMicco has signed the CLA. Thanks for the pull request! |
DanDeMicco
changed the title
pramodsum
approved these changes
Apr 17, 2018
Contributor
pramodsum
left a comment
pramodsum
left a comment
There was a problem hiding this comment.
Just test that it doesn't break on other browsers 👍
Contributor
Author
|
tested on ie, edge, chrome, firefox, and safari. All good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue was caused because toElement is not supported in firefox, thus was returning undefined and was being replaced with event.target in a later method, which is the dialog itself. Replaced with relatedTarget which is cross browser