feat(region): Connect region components to store#416
Merged
jstoffan merged 3 commits intobox:masterfrom Apr 9, 2020
Merged
Conversation
jstoffan
force-pushed
the
add-region-redux
branch
from
849d7ae to
a0e8e1e
Compare
Collaborator
|
This approach looks good |
ConradJChan
reviewed
Apr 8, 2020
jstoffan
force-pushed
the
add-region-redux
branch
2 times, most recently
from
49ef259 to
d107c51
Compare
jstoffan
force-pushed
the
add-region-redux
branch
from
443f70f to
b84b958
Compare
ConradJChan
approved these changes
Apr 9, 2020
mingzexiao6
reviewed
Apr 9, 2020
| position: absolute; | ||
| top: 0; | ||
| top: 15px; // Padding on each page as provided by Preview SDK | ||
| bottom: 15px; // Padding on each page as provided by Preview SDK |
Contributor
There was a problem hiding this comment.
Should these value be put into a variable?
mingzexiao6
reviewed
Apr 9, 2020
| getPageNumber(pageEl: HTMLElement): string { | ||
| return pageEl.dataset.pageNumber || '1'; | ||
| getPageNumber(pageEl: HTMLElement): number { | ||
| return parseInt(pageEl.dataset.pageNumber || '', 10) || 1; |
Contributor
There was a problem hiding this comment.
may be parseInt(pageEl.dataset.pageNumber || '1', 10)
Collaborator
Author
There was a problem hiding this comment.
Yeah, but the current form protects against NaN if pageNumber is a weird string for some reason. It seems minor either way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.