feat(hotkeys): Attach event listener to real DOM#521
Merged
mergify[bot] merged 1 commit intobox:masterfrom Jun 19, 2020
Merged
Conversation
jstoffan
reviewed
Jun 19, 2020
| Pick<FormikProps<FormValues>, 'errors' | 'setFieldValue' | 'values'>; | ||
|
|
||
| // export for test purpose | ||
| export const handleKeyDown = (handleCancel: () => void) => (event: KeyboardEvent): void => { |
Collaborator
There was a problem hiding this comment.
We should avoid testing the internals of the component whenever possible. Can we mount this component and set up a keydown listener on its parent document to make sure it doesn't get hit?
jstoffan
reviewed
Jun 19, 2020
jstoffan
reviewed
Jun 19, 2020
| event.nativeEvent.stopImmediatePropagation(); | ||
|
|
||
| onCancel(getFormattedCommentText(editorState).text); | ||
| handleCancel(); |
Collaborator
There was a problem hiding this comment.
Nice, this is a good change.
jstoffan
approved these changes
Jun 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.