fix(log): Fix resin isCurrentFileVersion is always true#542
Merged
mergify[bot] merged 1 commit intobox:masterfrom Jul 22, 2020
Merged
fix(log): Fix resin isCurrentFileVersion is always true#542mergify[bot] merged 1 commit intobox:masterfrom
mergify[bot] merged 1 commit intobox:masterfrom
Conversation
Collaborator
|
This seems like a |
jstoffan
reviewed
Jul 22, 2020
src/common/BaseAnnotator.ts
Outdated
| fileId: file.id, | ||
| fileVersionId: fileOptionsVersionId ?? fileVersionId, | ||
| isCurrentFileVersion: !fileOptionsVersionId || fileOptionsVersionId === fileVersionId, | ||
| isCurrentFileVersion: !fileOptionsVersionId || !!fileOptionsValue?.isCurrentFileVersion, |
Collaborator
There was a problem hiding this comment.
Should we add a comment for fileVersionId that it's always the currently-previewed version id?
mingzexiao6
changed the title
jstoffan
approved these changes
Jul 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs to merge box/box-ui-elements#2249 first.