feat(highlight): Change cursor when hovering over text#547
Merged
mergify[bot] merged 3 commits intobox:masterfrom Jul 30, 2020
Merged
feat(highlight): Change cursor when hovering over text#547mergify[bot] merged 3 commits intobox:masterfrom
mergify[bot] merged 3 commits intobox:masterfrom
Conversation
jstoffan
reviewed
Jul 29, 2020
jstoffan
suggested changes
Jul 29, 2020
Collaborator
jstoffan
left a comment
jstoffan
left a comment
There was a problem hiding this comment.
We should reconsider our approach to keep things decoupled and reusable.
mingzexiao6
force-pushed
the
cursor-hover-text
branch
from
b4a631a to
7767827
Compare
mingzexiao6
force-pushed
the
cursor-hover-text
branch
from
7767827 to
4d7ce98
Compare
jstoffan
reviewed
Jul 30, 2020
mingzexiao6
force-pushed
the
cursor-hover-text
branch
from
4d7ce98 to
6932b9f
Compare
jstoffan
reviewed
Jul 30, 2020
jstoffan
reviewed
Jul 30, 2020
Collaborator
jstoffan
left a comment
jstoffan
left a comment
There was a problem hiding this comment.
LGTM, just needs tests.
mingzexiao6
force-pushed
the
cursor-hover-text
branch
from
d6c0280 to
0b445d0
Compare
jstoffan
approved these changes
Jul 30, 2020
| return this.annotatedEl ? Array.from(this.annotatedEl.querySelectorAll('.page')) : []; | ||
| } | ||
|
|
||
| handleChangeMode = ({ mode }: { mode: Mode }): void => { |
Contributor
Author
There was a problem hiding this comment.
I actually followed the naming convention in BaseAnnotator like handleSetVisible and handleSetActive
jstoffan
approved these changes
Jul 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to merge box/box-content-preview#1239 first