feat(highlights): Create in highlight mode#573
Merged
ConradJChan merged 9 commits intobox:masterfrom Sep 5, 2020
Merged
Conversation
mingzexiao6
reviewed
Sep 2, 2020
jstoffan
reviewed
Sep 2, 2020
jstoffan
reviewed
Sep 2, 2020
jstoffan
reviewed
Sep 2, 2020
ConradJChan
force-pushed
the
highlight-mode
branch
from
c2f2eb0 to
0aa4041
Compare
mingzexiao6
reviewed
Sep 3, 2020
ConradJChan
force-pushed
the
highlight-mode
branch
from
170635c to
6761ed9
Compare
ConradJChan
force-pushed
the
highlight-mode
branch
from
6761ed9 to
2683828
Compare
mingzexiao6
reviewed
Sep 4, 2020
mingzexiao6
previously approved these changes
Sep 4, 2020
jstoffan
reviewed
Sep 4, 2020
added 7 commits
September 4, 2020 11:06
ConradJChan
force-pushed
the
highlight-mode
branch
from
93ba6a8 to
996553d
Compare
jstoffan
previously approved these changes
Sep 4, 2020
Collaborator
jstoffan
left a comment
jstoffan
left a comment
There was a problem hiding this comment.
Few minor comments, but otherwise LGTM.
| test('should call setActiveAnnotationId', () => { | ||
| const wrapper = getWrapper(); | ||
| wrapper.find(HighlightList).simulate('select', '123'); | ||
| (wrapper.find(HighlightList).prop('onSelect') as Function)('123'); |
Collaborator
There was a problem hiding this comment.
Is the cast needed here and for onClick? It looks like it's not needed in other tests.
Contributor
Author
There was a problem hiding this comment.
It is because the onSelect prop is typed as optional
Collaborator
There was a problem hiding this comment.
We should probably allow the non-null assertion in tests. It's actually safer than a cast, in this case, since it maintains the true type. Can be done later, though.
| range: mockRange, | ||
| }); | ||
| expect(defaults.getSelection).toHaveBeenCalled(); | ||
| expect(setSelectionAction).toHaveBeenCalled(); |
Collaborator
There was a problem hiding this comment.
Looking at this again, it seems like we could pass in store with the shape we want and let the selectors do their thing, removing the need to mock them. Could be done in a follow-up, though.
jstoffan
approved these changes
Sep 4, 2020
mingzexiao6
approved these changes
Sep 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: