feat(discoverability): Reorder RegionCreator before RegionList#597
Merged
ConradJChan merged 2 commits intobox:masterfrom Sep 22, 2020
Merged
feat(discoverability): Reorder RegionCreator before RegionList#597ConradJChan merged 2 commits intobox:masterfrom
ConradJChan merged 2 commits intobox:masterfrom
Conversation
mingzexiao6
reviewed
Sep 21, 2020
ConradJChan
force-pushed
the
reorder-regioncreator
branch
from
db03b1d to
84503fb
Compare
mingzexiao6
approved these changes
Sep 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This attempts to solve the problem that when discoverability feature is enabled, existing region annotations are not clickable anymore because the
RegionCreatornormally is on top of theRegionList.As a part of this commit, the
featuresare committed to the redux store.A separate change would be needed in Preview SDK to turn off
pointer-eventsfor the region annotation targets and highlight annotation targets when in explicit create region mode. See: box/box-content-preview#1262TODO: