Skip to content

fix(popuplayer): Only render PopupReply for staged location #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ConradJChan merged 1 commit into from
Sep 29, 2020
Merged

fix(popuplayer): Only render PopupReply for staged location #607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/popup/PopupLayer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ const PopupLayer = (props: Props): JSX.Element | null => {

return (
<>
{canCreate && canReply && reference && (
{canCreate && canReply && reference && staged && (
<div className="ba-PopupLayer-popup">
<PopupReply
isPending={isPending}
Expand Down
7 changes: 6 additions & 1 deletion src/popup/__tests__/PopupLayer-test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,15 @@ describe('PopupLayer', () => {
expect(wrapper.exists(PopupReply)).toBe(false);
});

test('should render PopupReply if promoting a highlight', () => {
test('should render PopupReply if promoting a highlight and staged exists', () => {
const wrapper = getWrapper({ mode: Mode.NONE, isPromoting: true });
expect(wrapper.exists(PopupReply)).toBe(true);
});

test('should not render PopupReply if promoting a highlight but staged does not exist', () => {
const wrapper = getWrapper({ mode: Mode.NONE, isPromoting: true, staged: null });
expect(wrapper.exists(PopupReply)).toBe(false);
});
});

describe('event handlers', () => {
Expand Down